Unified emulator settings for Firestore #1690

samtstern · 2020-06-19T17:00:46Z

Follow up to #1672 but for FirebaseFirestore

Note:

This now throws an IlegalStateException if the developer tries to set the host through the EmulatedServiceSettings as well as FirebaseFirestoreSettings. The settings method already throws unchecked exceptions so I thought this was the correct behavior, but I could convert it to a warning.

google-oss-bot · 2020-06-19T17:08:38Z

The public api surface has changed for the subproject firebase-firestore:
error: Added field com.google.firebase.firestore.FirebaseFirestore.EMULATOR [AddedField]

Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly.

google-oss-bot · 2020-06-19T17:08:39Z

Binary Size Report

Affected SDKs

firebase-common

Type Base (59db590) Head (0598f8a1) Diff

aar ? 38.1 kB ? (?)

apk (aggressive) ? 82.7 kB ? (?)

apk (debug) ? 772 kB ? (?)

apk (release) ? 637 kB ? (?)
firebase-components

Type Base (59db590) Head (0598f8a1) Diff

aar ? 34.5 kB ? (?)

apk (aggressive) ? 11.0 kB ? (?)

apk (debug) ? 35.9 kB ? (?)

apk (release) ? 25.4 kB ? (?)
firebase-database-collection

Type Base (59db590) Head (0598f8a1) Diff

aar ? 34.2 kB ? (?)

apk (aggressive) ? 314 kB ? (?)

apk (debug) ? 1.07 MB ? (?)

apk (release) ? 913 kB ? (?)
firebase-firestore

Type Base (59db590) Head (0598f8a1) Diff

aar ? 996 kB ? (?)

apk (aggressive) ? 461 kB ? (?)

apk (debug) ? 3.79 MB ? (?)

apk (release) ? 3.16 MB ? (?)
protolite-well-known-types

Type Base (59db590) Head (0598f8a1) Diff

aar ? 998 kB ? (?)

apk (aggressive) ? 140 kB ? (?)

apk (debug) ? 768 kB ? (?)

apk (release) ? 657 kB ? (?)

Test Logs

Head (0598f8a1): https://android-ci.firebaseopensource.com/view/gcs/android-ci/pr-logs/pull/firebase_firebase-android-sdk/1690/binary-size/1275537297248358406

Notes

Head commit (0598f8a1) is created by Prow via merging commits: 59db590 d90d91f.

google-oss-bot · 2020-06-19T17:10:30Z

Coverage Report

Affected SDKs

`firebase-firestore`

SDK overall coverage changed from 45.76% (59db590) to 46.71% (0598f8a1) by +0.95%.

Click to show coverage changes in 13 files.

Filename	Base (`59db590`)	Head (0598f8a1)	Diff
AbstractStream.java	34.52%	36.90%	+2.38%
AsyncQueue.java	69.85%	76.88%	+7.04%
ComponentProvider.java	97.14%	100.00%	+2.86%
Datastore.java	31.08%	33.78%	+2.70%
DocumentReference.java	11.68%	13.14%	+1.46%
EmptyCredentialsProvider.java	12.50%	37.50%	+25.00%
FirebaseClientGrpcMetadataProvider.java	0.00%	52.94%	+52.94%
FirebaseFirestore.java	0.00%	43.38%	+43.38%
FirebaseFirestoreSettings.java	31.03%	67.24%	+36.21%
FirestoreClient.java	0.00%	33.67%	+33.67%
FirestoreMultiDbComponent.java	0.00%	66.67%	+66.67%
FirestoreRegistrar.java	0.00%	100.00%	+100.00%
MemoryComponentProvider.java	96.55%	100.00%	+3.45%

Test Logs

Notes

HTML coverage reports can be produced locally with ./gradlew <product>:checkCoverage.
Report files are located at <product-build-dir>/reports/jacoco/.

Head commit (0598f8a1) is created by Prow via merging commits: 59db590 d90d91f.

google-oss-bot · 2020-06-19T19:51:09Z

The public api surface has changed for the subproject firebase-firestore:
error: Added field com.google.firebase.firestore.FirebaseFirestore.EMULATOR [AddedField]

Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly.

firebase-firestore/src/main/java/com/google/firebase/firestore/FirebaseFirestore.java

…or-settings

samtstern · 2020-06-22T17:11:16Z

Note: the failure in the api file comes from messaging:

> Task :firebase-inappmessaging:apiInformation FAILED
Aborting: Your changes have resulted in differences in the signature file
for the public API.
The changes may be compatible, but the signature file needs to be updated.
Diffs:
--- /home/prow/go/src/github.com/firebase/firebase-android-sdk/firebase-inappmessaging/api.txt	2020-06-22 16:47:15.984360721 +0000
+++ /home/prow/go/src/github.com/firebase/firebase-android-sdk/build/apiinfo/firebase-inappmessaging_api.txt	2020-06-22 16:52:35.872100325 +0000
@@ -18,7 +18,7 @@
     method public void setAutomaticDataCollectionEnabled(boolean);
     method public void setMessageDisplayComponent(@NonNull com.google.firebase.inappmessaging.FirebaseInAppMessagingDisplay);
     method public void setMessagesSuppressed(@NonNull Boolean);
-    method public void triggerEvent(String);
+    method public void triggerEvent(@NonNull String);
   }

This could be because the api check job was silently failing sometimes before the latest change by @rosariopfernandes

thatfiredev · 2020-06-22T18:15:34Z

@samtstern the same error occurred on #1693 . Should be fixed by #1699

firebase-firestore/src/main/java/com/google/firebase/firestore/FirebaseFirestore.java

firebase-firestore/src/test/java/com/google/firebase/firestore/FirebaseFirestoreTest.java

…or-settings

samtstern · 2020-06-23T18:35:13Z

@schmidt-sebastian all review comments address, thank you!

samtstern · 2020-06-23T18:48:25Z

Not sure what this is about:

* What went wrong:
Execution failed for task ':checkDebugDuplicateClasses'.
> 1 exception was raised by workers:
  java.lang.RuntimeException: java.lang.RuntimeException: Duplicate class com.google.protobuf.AbstractMessageLite found in modules protobuf-javalite-3.11.0.jar (com.google.protobuf:protobuf-javalite:3.11.0) and protobuf-lite-3.0.1.jar (com.google.protobuf:protobuf-lite:3.0.1)
  Duplicate class com.google.protobuf.AbstractMessageLite$Builder found in modules protobuf-javalite-3.11.0.jar (com.google.protobuf:protobuf-javalite:3.11.0) and protobuf-lite-3.0.1.jar (com.google.protobuf:protobuf-lite:3.0.1)
  Duplicate class com.google.protobuf.AbstractMessageLite$Builder$LimitedInputStream found in modules protobuf-javalite-3.11.0.jar (com.google.protobuf:protobuf-javalite:3.11.0) and protobuf-lite-3.0.1.jar (com.google.protobuf:protobuf-lite:3.0.1)
  Duplicate class com.google.protobuf.AbstractParser found in modules protobuf-javalite-3.11.0.jar (com.google.protobuf:protobuf-javalite:3.11.0) and protobuf-lite-3.0.1.jar (com.google.protobuf:protobuf-lite:3.0.1)

firebase-firestore/src/test/java/com/google/firebase/firestore/FirebaseFirestoreTest.java

…or-settings

google-oss-bot · 2020-06-23T21:21:46Z

@samtstern: The following test failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
smoke-tests	`d90d91f`	link	`/test smoke-tests`

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

samtstern · 2020-06-24T14:29:52Z

@rlazo says we can merge this anyway, so merging.

Unified emulator settings for Firestore

c621f5b

googlebot added the cla: yes Override cla label Jun 19, 2020

google-oss-bot added the size/L label Jun 19, 2020

samtstern requested a review from schmidt-sebastian June 19, 2020 17:01

samtstern assigned schmidt-sebastian Jun 19, 2020

Merge branch 'master' into ss-firestore-emulator-settings

b307898

samtstern mentioned this pull request Jun 19, 2020

Functions unified emulator settings #1688

Merged

Hide new constants

1a151bb

samtstern mentioned this pull request Jun 19, 2020

re-generate rtdb's api.txt and fail build if an error occurs parsing the file #1692

Merged

thatfiredev reviewed Jun 22, 2020

View reviewed changes

firebase-firestore/src/main/java/com/google/firebase/firestore/FirebaseFirestore.java Outdated Show resolved Hide resolved

Merge remote-tracking branch 'origin/master' into ss-firestore-emulat…

f9ff9d6

…or-settings

samtstern mentioned this pull request Jun 22, 2020

Quiet logging for emulators:exec firebase/firebase-tools#2390

Open

schmidt-sebastian reviewed Jun 23, 2020

View reviewed changes

schmidt-sebastian assigned samtstern and unassigned schmidt-sebastian Jun 23, 2020

samtstern added 2 commits June 23, 2020 14:34

Respond to Sebastian's review comments

85b6170

Merge remote-tracking branch 'origin/master' into ss-firestore-emulat…

a79f753

…or-settings

samtstern assigned schmidt-sebastian and unassigned samtstern Jun 23, 2020

samtstern requested a review from schmidt-sebastian June 23, 2020 18:35

schmidt-sebastian reviewed Jun 23, 2020

View reviewed changes

firebase-firestore/src/test/java/com/google/firebase/firestore/FirebaseFirestoreTest.java Show resolved Hide resolved

schmidt-sebastian removed their assignment Jun 23, 2020

Add one more test

9d499c1

samtstern requested a review from schmidt-sebastian June 23, 2020 19:30

samtstern assigned schmidt-sebastian Jun 23, 2020

schmidt-sebastian approved these changes Jun 23, 2020

View reviewed changes

schmidt-sebastian assigned samtstern and unassigned schmidt-sebastian Jun 23, 2020

Merge remote-tracking branch 'origin/master' into ss-firestore-emulat…

d90d91f

…or-settings

samtstern merged commit 0eaca5e into master Jun 24, 2020

samtstern mentioned this pull request Jun 24, 2020

Un-hide EmulatorSettings API #1712

Merged

2 tasks

samtstern mentioned this pull request Jul 22, 2020

Re-implement Unified Emulator Settings #1802

Merged

2 tasks

firebase locked and limited conversation to collaborators Jul 25, 2020

kaibolay deleted the ss-firestore-emulator-settings branch September 14, 2022 17:55

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Unified emulator settings for Firestore #1690

Unified emulator settings for Firestore #1690

samtstern commented Jun 19, 2020

google-oss-bot commented Jun 19, 2020

google-oss-bot commented Jun 19, 2020 •

edited

Loading

`firebase-common`

`firebase-components`

`firebase-database-collection`

`firebase-firestore`

`protolite-well-known-types`

google-oss-bot commented Jun 19, 2020 •

edited

Loading

`firebase-firestore`

google-oss-bot commented Jun 19, 2020

samtstern commented Jun 22, 2020

thatfiredev commented Jun 22, 2020

samtstern commented Jun 23, 2020

samtstern commented Jun 23, 2020

google-oss-bot commented Jun 23, 2020

samtstern commented Jun 24, 2020

Unified emulator settings for Firestore #1690

Unified emulator settings for Firestore #1690

Conversation

samtstern commented Jun 19, 2020

google-oss-bot commented Jun 19, 2020

google-oss-bot commented Jun 19, 2020 • edited Loading

Binary Size Report

Affected SDKs

firebase-common

firebase-components

firebase-database-collection

firebase-firestore

protolite-well-known-types

Test Logs

Notes

google-oss-bot commented Jun 19, 2020 • edited Loading

Coverage Report

Affected SDKs

firebase-firestore

Test Logs

Notes

google-oss-bot commented Jun 19, 2020

samtstern commented Jun 22, 2020

thatfiredev commented Jun 22, 2020

samtstern commented Jun 23, 2020

samtstern commented Jun 23, 2020

google-oss-bot commented Jun 23, 2020

samtstern commented Jun 24, 2020

google-oss-bot commented Jun 19, 2020 •

edited

Loading

`firebase-common`

`firebase-components`

`firebase-database-collection`

`firebase-firestore`

`protolite-well-known-types`

google-oss-bot commented Jun 19, 2020 •

edited

Loading

`firebase-firestore`